-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(knative): bump to 1.15.2 #1517
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please document the upstream location from where the template files are copied. would be good to add a script which one can run to download so that future upgrades are automated as much as possible.
can we point or list all the tests we run on such upgrade. |
@@ -21,6 +21,9 @@ PATCH_1_FIX=$'# eg. \'{{ `{{.Name}}-{{.Namespace}}.{{ index .Annotations "sub"}} | |||
PATCH_2=$'logging.request-log-template: \'{"httpRequest": {"requestMethod": "{{.Request.Method}}", "requestUrl": "{{js .Request.RequestURI}}", "requestSize": "{{.Request.ContentLength}}", "status": {{.Response.Code}}, "responseSize": "{{.Response.Size}}", "userAgent": "{{js .Request.UserAgent}}", "remoteIp": "{{js .Request.RemoteAddr}}", "serverIp": "{{.Revision.PodIP}}", "referer": "{{js .Request.Referer}}", "latency": "{{.Response.Latency}}s", "protocol": "{{.Request.Proto}}"}, "traceId": "{{index .Request.Header "X-B3-Traceid"}}"}\'' | |||
PATCH_2_FIX=$'logging.request-log-template: \'{"httpRequest": {"requestMethod": "{{ `{{.Request.Method}}", "requestUrl": "{{js .Request.RequestURI}}", "requestSize": "{{.Request.ContentLength}}", "status": {{.Response.Code}}, "responseSize": "{{.Response.Size}}", "userAgent": "{{js .Request.UserAgent}}", "remoteIp": "{{js .Request.RemoteAddr}}", "serverIp": "{{.Revision.PodIP}}", "referer": "{{js .Request.Referer}}", "latency": "{{.Response.Latency}}s", "protocol": "{{.Request.Proto}}"}, "traceId": "{{index .Request.Header "X-B3-Traceid"}}` }}"}\'' | |||
|
|||
PATCH_3=$'# serving.knative.dev/revision: {{revision-name}}' | |||
PATCH_3_FIX=$'# serving.knative.dev/revision: {{ `{{revision-name}}` }}' | |||
|
|||
# Base URLs | |||
SERVING_URL=https://github.com/knative/serving/releases/download/knative-v${SERVING_TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, this is the upgrade location. found it
found it. https://github.com/mesosphere/charts/pull/1517/files#r1795775689
|
What type of PR is this?
Feat
What this PR does/ why we need it:
Creates new knative chart with latest 1.15.2 version.
Which issue(s) this PR fixes:
https://jira.nutanix.com/browse/NCN-102804
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist